(WIP) feat(navigation): enhance setDestination and setDestinations methods with routeToken support #383
+200
−213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with routeToken support - Added routeToken parameter to setDestination and setDestinations methods in NavModule. - Updated TypeScript definitions to include routeToken in NavigationController interface. - Implemented logging for routeToken usage in setDestinations method. - Adjusted logic to prioritize routeToken over routingOptions when setting destinations. This change improves navigation flexibility by allowing pre-calculated routes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…with routeToken support
TODO:
This change improves navigation flexibility by allowing pre-calculated routes.
Fixes #343